Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SNS topics fetch panics on errors #2784

Merged
merged 4 commits into from
Dec 1, 2024
Merged

Fix SNS topics fetch panics on errors #2784

merged 4 commits into from
Dec 1, 2024

Conversation

jeniawhite
Copy link
Contributor

@jeniawhite jeniawhite commented Nov 28, 2024 •
edited
Loading

Summary of your changes

Agentless agents were having panics on fetching SNS topics.

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

@jeniawhite jeniawhite requested a review from a team as a code owner November 28, 2024 08:46
@mergify Mergify
Copy link

mergify bot commented Nov 28, 2024

This pull request does not have a backport label. Could you fix it @jeniawhite? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-v8.x has been added to help with the transition to the new branch 8.x.

@moukoublen
Copy link
Member

Should we backport to 8.17 as well?

@kubasobon @oren-zohar ?

@kubasobon
Copy link
Member

@moukoublen Yeah, I think nil-reference panic fixes merit a backport. I'm adding a label.

@jeniawhite jeniawhite enabled auto-merge (squash) December 1, 2024 13:13
@jeniawhite jeniawhite merged commit 3dc0d07 into elastic:main Dec 1, 2024
10 checks passed
mergify bot pushed a commit that referenced this pull request Dec 1, 2024
@jeniawhite @mergify
Fix SNS topics fetch panics on errors (#2784)
9dd9532 
* SNS panic fix

* Fixing lint and tests

* Linter

(cherry picked from commit 3dc0d07)
@mergify mergify bot mentioned this pull request Dec 1, 2024
Merged
5 tasks
romulets pushed a commit that referenced this pull request Dec 2, 2024
@mergify @jeniawhite
[8.x](backport #2784) Fix SNS topics fetch panics on errors (#2796)
06f781c 
Fix SNS topics fetch panics on errors (#2784)

* SNS panic fix

* Fixing lint and tests

* Linter

(cherry picked from commit 3dc0d07)

Co-authored-by: Evgeniy Belyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moukoublen moukoublen moukoublen approved these changes

Assignees

@jeniawhite jeniawhite

Labels
backport-v8.x backport-v8.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Asset Inventory] Cloudbeat panics if SNS topic fetching returns error
3 participants
@jeniawhite @moukoublen @kubasobon